search

FoundationGames / Sandwichable

Customizable Sandwich mod for Minecraft
MIT License
32 stars 28 forks source link

[Gameplay Bug] Salt lake water rendering issue #74

Open milkev opened 3 years ago

milkev commented 3 years ago

Description after breaking the salt blocks in a salt lake, the desalinator no longer works, but the water remains the light-salt-lake color until the chunks are reloaded. How To Reproduce Find salt lake, or place salty stone with water ontop of it, break the salty stone. The water will remain the lighter colour even when removing/replacing it, the desalinator will not work (so the desalinator logic is working correctly). The water will return to the normal colour after leaving and reloading the area, or leaving and rejoining the world. Expected Behavior water colour is consistent with the state of that Y column of the world.

Media 2021-01-21_21 08 17 2021-01-21_21 08 34

FoundationGames commented 3 years ago

This is a vanilla issue. Biome colors are cached upon chunk reload, and the place where I modify the water color is in that method. If I modified the water block's color provider directly, any block updates involving water would be extremely client-side laggy.