search

FoundationGames / Sandwichable

Customizable Sandwich mod for Minecraft
MIT License
32 stars 28 forks source link

[Gameplay Bug] Weird salt lake generation #97

Closed sleepy-evelyn closed 3 years ago

sleepy-evelyn commented 3 years ago

Description Salt lake generation seems very derpy and doesn't seem to properly take into account other late generated features within the world. Some images of this weird generation are provided below. It seems to also conflict with AE2 meteors pretty badly. Happens on https://github.com/The-Tiny-Taters/TTTM-AOF which is basically AOF3 but with some additional mods ontop running currently on version 2.7.1

How To Reproduce Fly around the world a bit and have a look for some salt lakes

Expected Behavior Better placement of the features

Media

AE2 meteor overlapping generation image

Chunk cutting into the generation Image and Image

FoundationGames commented 3 years ago

If a meteor crashed into the earth nearby a salt lake, what would you expect to happen to the salt lake? As far as I can tell generation is working exactly as intended with the salt lakes generating on the previous step compared to the meteors. The salt lake has been properly destroyed by the meteor. As for the cut off bits of water, that is to be expected when a water body generates above sea level and is generated over by a feature as large as a meteor crater.

sleepy-evelyn commented 3 years ago

Whoops I forgot to include the last image. Apologies This seems to show the lake generating on-top of the meteor

https://media.discordapp.net/attachments/814452859273216070/835626569426010183/2021-04-24_20.png?width=2560&height=1496

sleepy-evelyn commented 3 years ago

This seems at least on first glance to be kind of a joint issue anyway though, it seems to happen very frequently however, I mean these 3 images are from just about 15 minutes of flying around so maybe AE2 meteor generation could be considered and it could avoid being placed near them. I don't know enough worldgen though so i'm not sure how easy this would be or if it's even possible

FoundationGames commented 3 years ago

That last image is a result of chunk generation order, a vanilla bug i cannot fix. Press F3+G and see if a chunk boundary fits into that slice taken out of the salt pool, it most likely will.

However the bigger issue I notice with this is that salt pools seem to choose to generate right next to AE2 meteors. I feel like this could be caused by the exact same rule that causes diamonds (pre-1.18) to generate directly offset to clay blobs in swamps. The two features likely use the same decorator with extremely similar configurations.

sleepy-evelyn commented 3 years ago

Agreed yeah your explanation makes more sense and yes the last image splits exactly at the chunk border so that's our end. Think threaded anvil chunk storage must have been having a field day.

sleepy-evelyn commented 3 years ago

Couldn't reproduce after searching for features for about 30 minutes