Foundry-Workshop / Item-Macro

Store macros in your items, execute them from your character sheet or from your favorite automation module!
MIT License
1 stars 4 forks source link

[Enhancement] Foundry v12 Support #18

Open mcabel opened 2 months ago

mcabel commented 2 months ago

Can you please add support for foundry version 12 with dnd 3.3.1 + ?

Forien commented 2 months ago

Is there any specific issue you are encountering? If so, a bug report would be appreciated.

mcabel commented 2 months ago

I'll keep testing and report a bug if I find anything more specific. Thanks for your attention.

BlackBadger777 commented 2 months ago

I just tried using ItemMacro with v12 and DnD5e 3.3.1. Unfortunately, it doesn't seem to be functional. A macro I put on an item is supposed to execute and present a dialog instead of outputting the item to chat, but the macro doesn't fire and the item is sent to chat. There is no error message in the console. Executing the macro manually from itemmacro's sheet will trigger the macro in its intended form.

I can file a separate bug report, too, if needed.

Forien commented 2 months ago

I just tried using ItemMacro with v12 and DnD5e 3.3.1. Unfortunately, it doesn't seem to be functional. A macro I put on an item is supposed to execute and present a dialog instead of outputting the item to chat, but the macro doesn't fire and the item is sent to chat. There is no error message in the console. Executing the macro manually from itemmacro's sheet will trigger the macro in its intended form.

I can file a separate bug report, too, if needed.

Have you enabled the Override default macro execution in the module's settings?

BlackBadger777 commented 2 months ago

Ah, shoot. I thought I had set up my module settings exactly as in my old world, but this one slipped my notice. I apologize! Now it seems to work, although it throws an error message when used with Tidy5e sheets. But that is a separate issue, which I will take to that module's author. Thank you so much for the quick reply!

fegarza7 commented 2 months ago

I second this, no issues encountered it just looks yellow on my modules. image