search

FoundryDevelopmentConsortium / Knowledge-Recalled-PF2e-FVTT

Creative Commons Zero v1.0 Universal
0 stars 3 forks source link

getLowestSave #24

Closed AlecHolloway closed 3 months ago

AlecHolloway commented 1 year ago

NPCModel.js -> class NPCModel -> getLowestSave() -> removeFlag() The remove flag function takes in two parameters: actor and flagPath. Currently the flagPath is set to lowestSave.lowestSaveValue. The lowestSave is set above like so: const lowestSave = Math.min(fortitudeSaveValue, willSaveValue, reflexSaveValue); This however only sets the value and the function does not recognize the full path. We will need to change the lowestSave to lowestSaveValue and find a way to store the actual path ie. ( fortSave, willSave, refSave ) . value

christianhturner commented 1 year ago

Discord discussion thread Please continue conversation here and provide work notes on the issue thread.

christianhturner commented 1 year ago

Resolved: the issue was that the remove flag function was expecting a string of the path to the value, but I was instead just passing the value. Improvement: created jsdoc for remove flag.

christianhturner commented 1 year ago

Awaiting merge