Founntain / osuplayer

Official osu!player repository. osu!player is a music player for the game osu! made by Dean 'peppy' Herbert. Written in the cross-platform framework AvaloniaUI
MIT License
62 stars 6 forks source link

[BUG] Background colors behaving weirdly, all options having hight transparency #251

Closed Quiel245 closed 9 months ago

Quiel245 commented 9 months ago

Describe the bug every time i open the app the background is on a grey color that is extremely uncomfortable for me, and when i try to change it with the "window background color" option it turns uncomfortably transparent, independent of the color i choose, and on restarting the app it will always start on the previously mentioned gray coloring also, the "Use song background image" isn't working too

To Reproduce Steps to reproduce the behavior:

  1. Open the app
  2. Click on "Settings"
  3. Scroll down to window background color
  4. change it to any option
  5. See the weird transparency

Expected behavior I expected the app to open always with the currently selected background color, and to not have any transparency on options other than the "Transparent" one

Screenshots https://github.com/Founntain/osuplayer/assets/99212613/3c475ffc-a317-46cb-a78a-44cfb2c257ee

Desktop:

Additional context I don't know if that gray color is just what "none" is supposed to look like, but still

This started after the 2023.1118.1 update, and still persists after 2023.1122.0

Founntain commented 9 months ago

This indeed not intended and might be a bug from migrating to Avalonia 11. I'll take a look tomorrow

Quiel245 commented 9 months ago

Nice to know! thank you very much

Founntain commented 9 months ago

Quick Update I found out what the issue as and it also connects that the backgrounds are not working.

As you can see in the fixed version you can set the background color freely

Quiel245 commented 9 months ago

Oooh, awesome! Thank you again

Founntain commented 9 months ago

I really would appreciate when the new release is out and check if backgrounds work properly. If so please create a new issue then as I can't import songs on my WSL instance.

Quiel245 commented 9 months ago

Ookie dokie, As soon as it comes out and I'm able to i'll test it right away!

Founntain commented 9 months ago

Ookie dokie, As soon as it comes out and I'm able to i'll test it right away!

Sounds great! The Pull Request #253 just waits for @Cesan review!

Quiel245 commented 9 months ago

Yup @Founntain, it seems to be working fine now!
Only thing i'm not sure is that The "none" and "transparent" options are basically the same, is that how it is expected to be?

Little video showing how things are working now:

https://github.com/Founntain/osuplayer/assets/99212613/f5de078a-8110-40b3-b239-99fb6b3185dd

Founntain commented 9 months ago

Yup @Founntain, it seems to be working fine now! Only thing i'm not sure is that The "none" and transparent options are basically the same, is that how it is expected to be?

Yes it is expected. As those other options will always fallback to SolidColor (None)

TransparencyLevelHint = new[]
{
    // First Value to Try (Win 11 only) 
    WindowTransparencyLevel.Mica, 
    // Second Value to Try  (Win and Mac only)
    WindowTransparencyLevel.AcrylicBlur,     
    // Last Value (SolidColor)
    WindowTransparencyLevel.None
};
Quiel245 commented 9 months ago

ah i see, then it's all nice!

Founntain commented 9 months ago

ah i see, then it's all nice!

Basicly if you are on Windows you could select Acrylic if you dont like Mica etc. but if you Use Mica and cant select it it will use None for Linux

Quiel245 commented 9 months ago

hmm, thanks for the explanation, i think i got it better now!