search

FountainJS / generator-fountain-angular1

Yeoman 'fountain' generator to start a webapp with Angular 1
http://fountainjs.io
MIT License
95 stars 34 forks source link

No location to put images in #62

Closed mohitt closed 7 years ago

mohitt commented 7 years ago

https://github.com/Swiip/generator-gulp-angular

had assets/images ,

when you are not using any module loader and using only bower

raptdwar commented 7 years ago

gulp serve serve files from both .tmp folder and src folder, simply create the folders you need directly inside the src folder. when you gulp build, those files are copied to dist folder.

octavioamu commented 7 years ago

not if is used images in the css, the structure changes and not pointing to the images... also I create a folder with static jsons and not being copied to the dist I think the generator is very nice but taken out the image optimization is a big mistake http://fountainjs.io/gulp-angular/how-it-works/#images

josx commented 7 years ago

Would be great to have this feature as optional.

Swiip commented 7 years ago

Sorry but... We try to keep the generated projects as simple as possible. I don't think creating empty directory to indicate where to put assets is needed. Just put them where you want.

octavioamu commented 7 years ago

Having like optional is not having empty folder, and just putting a folder with images anywhere is not going to work in production. I think if the generator intent to be a general solution for projects, even small projects will have images, like css or JS all assets must be considerate in a multi propose generator.

On Nov 5, 2016 7:20 AM, "Matthieu Lux" notifications@github.com wrote:

Closed #62 https://github.com/FountainJS/generator-fountain-angular1/issues/62.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FountainJS/generator-fountain-angular1/issues/62#event-848754234, or mute the thread https://github.com/notifications/unsubscribe-auth/ABS5DeJb8fo3iCZU_e4KMgBtT82RL064ks5q7EpfgaJpZM4JwIyI .