FountainJS / generator-fountain-webapp

Yeoman 'fountain' generator to start a webapp
http://fountainjs.io
MIT License
967 stars 67 forks source link

Error message when running project: "Unnecessarily quoted property 'edit' found quote-props" #182

Open felipe-gdr opened 7 years ago

felipe-gdr commented 7 years ago

Description

I'm getting an error message when running npm run serve just after a fresh installation of this generator

Error Message & Stack Trace

ERROR in ./src/app/components/TodoTextInput.js

/Users/myusername/dev/jhipster-lab/fountain-webapp/src/app/components/TodoTextInput.js
  40:13  error  Unnecessarily quoted property 'edit' found  quote-props

✖ 1 problem (1 error, 0 warnings)

Config

Copy the content from .yo-rc.json:

{
  "generator-fountain-react": {
    "version": "1.0.0",
    "props": {
      "framework": "react",
      "modules": "webpack",
      "js": "babel",
      "ci": "",
      "css": "scss",
      "resolved": "/usr/local/lib/node_modules/generator-fountain-webapp/node_modules/generator-fountain-react/generators/app/index.js",
      "namespace": "fountain-react:app",
      "_": [],
      "sample": "todoMVC",
      "router": "router"
    }
  }
}

Environment

node -e "var os=require('os');console.log('Node.js ' + process.version + '\n' + os.platform() + ' ' + os.release())"
Node.js v6.10.0
darwin 15.6.0

yo --version
1.8.5

npm --version
3.10.10
felipe-gdr commented 7 years ago

The error message goes away when I removed the quotes from the edit property.

File: TodoTextInput.js:38-42

        className={
          classnames({
            'edit': this.props.editing,
            'new-todo': this.props.newTodo
          })}

After fix:

        className={
          classnames({
            edit: this.props.editing,
            'new-todo': this.props.newTodo
          })}
habpygo commented 7 years ago

Yep, that fixed it. Thanks a million!

besopmac commented 7 years ago

Thanks, Felipe!

mattinteractive commented 7 years ago

Yup, was having same issue, thanks for posting solution.

wr125 commented 7 years ago

Nice one, fixed the issue. Problem can be found near the bottom of the 'src/app/components' folder.

mphz commented 7 years ago

should be: className={ classnames({ edit: this.props.editing, 'new-todo': this.props.newTodo })}

original is: className={ classnames({ 'edit': this.props.jditing, 'new-todo': this.props.newTodo })}

mortensassi commented 7 years ago

Still in TodoTextInput.js 40:13 the singlequotes should be removed.

DamienBriggs commented 6 years ago

Fixed the issue for me also. Thanks!!!