FountainJS / generator-fountain-webapp

Yeoman 'fountain' generator to start a webapp
http://fountainjs.io
MIT License
967 stars 67 forks source link

Order of AngularJs in bower.json #193

Open thiagosbrito opened 7 years ago

thiagosbrito commented 7 years ago

Hi Guys,

First of all, thanks for the great job you guys've been done. It's awesome, I do use in every project that I do work.

Well, the issue is simple. When we generate a scaffold, AngularJs is the last item in bower.json dependencies. So, why this is a issue? Because, when its come to build version and we have for example angular-bootstrap timepicker and $locale.pt-br, the $locale are overrided from angular native $locale and this breaks the timepicker component.

"dependencies": {
    "angular-animate": "~1.5.3",
    "angular-cookies": "~1.5.3",
    "angular-touch": "~1.5.3",
    "angular-sanitize": "~1.5.3",
    "angular-messages": "~1.5.3",
    "angular-aria": "~1.5.3",
    "jquery": "~2.1.4",
    "angular-ui-router": "~0.2.15",
    "bootstrap-sass": "~3.3.5",
    "angular-bootstrap": "~0.14.3",
    "malarkey": "yuanqing/malarkey#~1.3.1",
    "angular-toastr": "~1.5.0",
    "moment": "~2.10.6",
    "animate.css": "~3.4.0",
    "angular-locale-pt-br": "^1.3.15",
    "angular": "~1.5.3"
  }

I could resolve the issue by putting AngularJs in first position of bower.json.

"dependencies": {
    "angular": "~1.5.3",
    "angular-animate": "~1.5.3",
    "angular-cookies": "~1.5.3",
    "angular-touch": "~1.5.3",
    "angular-sanitize": "~1.5.3",
    "angular-messages": "~1.5.3",
    "angular-aria": "~1.5.3",
    "jquery": "~2.1.4",
    "angular-ui-router": "~0.2.15",
    "bootstrap-sass": "~3.3.5",
    "angular-bootstrap": "~0.14.3",
    "malarkey": "yuanqing/malarkey#~1.3.1",
    "angular-toastr": "~1.5.0",
    "moment": "~2.10.6",
    "animate.css": "~3.4.0",
    "angular-locale-pt-br": "^1.3.15"
  }

If you guys find thats this isn't a issue, sorry.

Again , thanks for the incredible work!!