search

FountainJS / generator-fountain-webpack

Yeoman 'fountain' generator which handle the Webpack config
http://fountainjs.io
MIT License
4 stars 6 forks source link

Fixed duplication of vendor scripts in webpack build #53

Closed vedmaque closed 8 years ago

vedmaque commented 8 years ago

Resolves https://github.com/FountainJS/generator-fountain-webapp/issues/118

facultymatt commented 8 years ago

+1 to get this released!

zckrs commented 8 years ago

Confirmed.

In past PR we split output file.

zckrs commented 8 years ago

@vedmaque can you provide some explanations (or a doc link) on your fix with CommonsChunkPlugin please :-) ?

zckrs commented 8 years ago

Anyway good job :clap: and thank you :+1:

vedmaque commented 8 years ago

http://webpack.github.io/docs/list-of-plugins.html#commonschunkplugin

Probably, should add minChunks: Infinity option, but i'm not sure.

ps. Actually it works like black box. Yes, it has documentation, but you will never know what would happen if you change some params :sob: