search

FountainMC / FountainAPI

A 'simple but beautiful' Minecraft Server Plugin API
https://fountainmc.org/
MIT License
5 stars 5 forks source link

Shading for final API jar #8

Closed PizzaCrust closed 8 years ago

PizzaCrust commented 8 years ago
Techcable commented 8 years ago

Isn't this already handled in the implementation?

PizzaCrust commented 8 years ago

Yes, but they need to add the API jar to their classpath for their IDE. And the API Jar, doesn't contain Event4j. So, it'll impossible for them to create plugins without using the implementation's JAR.

Techcable commented 8 years ago

No I mean shouldn't the implementation be the one that has the shade plugin?

PizzaCrust commented 8 years ago

Yes, like I said above; developers should be able to use the API jar only, not implementation JAR.

phase commented 8 years ago

You can already use only the API jar. Running mvn package will create a jar that only contains the code needed for this project, aka the API. I know the README only has like two lines, but please read the README.

PizzaCrust commented 8 years ago

Nope, you'd still have to use Event4j's JAR on the classpath too.

Otherwise, events don't work.

phase commented 8 years ago

You have to use Event4J because that's part of the API. It's needed for the PluginManager, which is in the API.

phase commented 8 years ago

Oh wait you mean it's not being included. That's a problem :P

PizzaCrust commented 8 years ago

That is why i'm proposing this pull request.

phase commented 8 years ago

Merged in https://github.com/FountainMC/FountainAPI/commit/f2ada3139990ab4907f4e67390430059f3405bf0