FountainMC / FountainVanilla

FountainAPI implementation on NMS
MIT License
8 stars 2 forks source link

Basic entity implementation with new events implemented #7

Closed PizzaCrust closed 8 years ago

PizzaCrust commented 8 years ago

There's a duplicate commit. I don't know how it got there.

Techcable commented 8 years ago

I'll squash and reformat this :)

PizzaCrust commented 8 years ago

Thanks.

phase commented 8 years ago

I had a different idea for Entities. Instead of creating new Wet classes, we can have the Entity classes implement our interfaces and implement the methods inside the classes.

Techcable commented 8 years ago

@phase That'd make a much much bigger diff

phase commented 8 years ago

It would just add implements org.fountainmc.api.entity.Blah and add the methods at the bottom. I don't think it'd be too horrible.

PizzaCrust commented 8 years ago

Mixins :package:

phase commented 8 years ago

@Techcable A rebase might be better to keep the hook listener commit. Just reword them and remove the "merged github" commit.

phase commented 8 years ago

Merged in https://github.com/FountainMC/Fountain/commit/74f932d9bdd67cf83b341f932ce8699874813d0a and https://github.com/FountainMC/Fountain/commit/717c593066059e82f008bc36244d6448d2d9dbdb.

Techcable commented 8 years ago

@phase messed this up so I'll be doing this 😉 along with the other entity implementations.

Techcable commented 8 years ago

Nevermind, I guess he did merge it

phase commented 8 years ago

Yeah, because I'm a git wizard.