Better decompilation - Githubissues

FountainMC / FountainVanilla

FountainAPI implementation on NMS

MIT License

8 stars 2 forks source link

Open Techcable opened 8 years ago

Techcable commented 8 years ago

We need to improve the quality of the decompiled code.

[ ] Inner class naming
[ ] 4 space indentation
[ ] Automatically fix generics (if possible)
[ ] Use MCP parameter naming (if possible)
[ ] Use type based local variable naming like craftbukkit (integers go 'i', 'j', 'k', 'l')
- This 'var5' thing is stupid
[ ] Remove redundant varargs array creation
[ ] Remove redundant boxing

wgaylord commented 8 years ago

Why not use mcp and then our own patching script?

Techcable commented 8 years ago

@chibill We don't want to touch that. We literally can't redistribute/use their scripts without their written permission.

wgaylord commented 8 years ago

Yeah but same thing with there mappings.

phase commented 8 years ago

We could run the decompiled code through a formatter if FernFlower doesn't have options for it.