search

FourierFlows / FourierFlows.jl

Tools for building fast, hackable, pseudospectral partial differential equation solvers on periodic domains
https://bit.ly/FourierFlows
MIT License
207 stars 29 forks source link

Compat entry to avoid bug in CUDA v3.7.0 #310

Closed navidcy closed 2 years ago

navidcy commented 2 years ago

This PR puts an upper bound to CUDA on v3.6.4. With CUDA v3.7.0 I noticed that mul! was not working straight out of the box with CuArrays and (r)fftplans.

navidcy commented 2 years ago

(CUDA v3.7.0 breaking/bug was partly discussed in #309.)

maleadt commented 2 years ago

I'd be happy to quickly tag a bugfix release to avoid having to bound.

navidcy commented 2 years ago

Thanks @maleadt!

Perhaps this log is useful? https://buildkite.com/julialang/fourierflows-dot-jl/builds/213#e0fcfca5-415c-48c3-8b0b-56aad944ec65/252-450

I can also try to make a MWE if that would help!

navidcy commented 2 years ago

Note that the buildkite failures above with 3.4.2 and 3.5.0 were from some trivial show() method that needed updating. But the failure with 3.7.0 relates to mul! with CuArrays and fftplans....

navidcy commented 2 years ago

@maleadt, I tested it using CUDA#master @ 430787 and seems to work fine! So if you tag 3.7.1 I'll add a compat entry

CUDA = "^1, ^2.4.2, 3.0.0-3.6.4, ^3.7.1"

which should do the job. ;)

maleadt commented 2 years ago

https://github.com/JuliaRegistries/General/pull/53274