Fourmisain / AxesAreWeapons

A Fabric/(Neo)Forge Minecraft mod which disables the increased durability loss in combat and enables Looting for axes.
MIT License
4 stars 1 forks source link

Looting is mutually exclusive with Silk Touch (but not Fortune?) #1

Closed JumperREDACTED closed 3 years ago

JumperREDACTED commented 3 years ago

You can't put Silk Touch and Looting on the same axe. You can put Fortune and Looting on the same axe.

I assume Silk Touch and Looting should be compatible? If not, it would be nice if it was an option in the config.

Fourmisain commented 3 years ago

Ah, I've never put Silk Touch on an axe, so I wouldn't know! 😄

The reason for this is that Looting and Fortune are both "Luck" enchantments (as is Luck of the Sea) and Luck it is made to be incompatible with Silk Touch. Confusingly, Silk Touch is already made to be incompatible with Fortune, so it seems this is just an oversight on Mojang's side.

I agree that Looting should be compatible with Silk Touch (and with Fortune, as they affect different things), but just in case I'll make it an option to disable this if wanted.

Fourmisain commented 3 years ago

Implemented in https://github.com/Fourmisain/AxesAreWeapons/commit/38fbaae218f3c8df7106198b63cc068b680a17c8, new version is up and approved!