Fourmisain / AxesAreWeapons

A Fabric/(Neo)Forge Minecraft mod which disables the increased durability loss in combat and enables Looting for axes.
MIT License
4 stars 1 forks source link

Hoes with Sharpness V does not boost its damage #18

Closed KienNgoQwert closed 2 months ago

KienNgoQwert commented 2 months ago

my netherite hoe stayed 4 damage

Fourmisain commented 2 months ago

If you mean the damage value in the tooltip, that's normal vanilla behavior:

sword1 sword2

The weapon will still deal more damage when attacking. I just one-shot a cow with a sharpness 100 hoe.

KienNgoQwert commented 2 months ago

weird, i tested it against another player and its still 4

Fourmisain commented 2 months ago

How exactly did you test the damage?

Also, what version are you on? Any other mods?

KienNgoQwert commented 2 months ago
  1. Ask a guy to take off his armor to test the damage, he said it took 2 hearts (4 damage)
  2. 1.21 Quilt (0.26.4 beta-5 i think? its the latest version of quilt)
  3. Only performance mods, AAW is installed only server-side tho (if it helps, i have vanilla refresh installed server-side)
Fourmisain commented 2 months ago

Hm... not sure what's happening then. Axes Are Weapons doesn't actually modify Sharpness or the actual damage, it only makes the item enchantable (and changes the durability loss), so you should get the exact same result with a give command like /give @s netherite_hoe[minecraft:enchantments={sharpness:5}] on a vanilla server.

Gonna try if I can reproduce this.

KienNgoQwert commented 2 months ago

if it helps, apparently sharpness 10 does boost damage, but 5 does nada

Fourmisain commented 2 months ago

Hold on! Vanilla hoes only deal 1 damage in vanilla, even Netherite ones.

Sharpness V will increase that damage by 0.5 * level + 0.5 = 3, so we're up to 4. In other words, everything is working as expected!

Fourmisain commented 2 months ago

I should say: The "All Tools Are Weapons" options are mainly meant to be used in conjunction with other mods that change combat mechanics of those tools. It's basically just one piece of the puzzle.

KienNgoQwert commented 2 months ago

oh thank you i misread the stats

Fourmisain commented 2 months ago

P.S. I think in 1.21 it is also possible to change the damage of hoes via a datapack (e.g. by modifying the item's damage component) if you so wish.

k, gonna see this issue as resolved!