search

FourthState / plasma-mvp-rootchain

smart contract implementation according to the Plasma MVP spec.
Apache License 2.0
79 stars 24 forks source link

Create .gitattributes #37

Closed ldct closed 6 years ago

ldct commented 6 years ago

Create .gitattributes with the appropriate line to enable solidity syntax highlighting in the github web ui, as per github/linguist#3973

laskdaf commented 6 years ago

Thank you for your contribution. However, I don't see any syntax highlighting differences between master and your branch. Some solidity files are highlighted, while others are not. Is this an issue with the library? or does it take some time to show up.

ldct commented 6 years ago

Someone from github told me it's a caching issue.

Le mar. 1 mai 2018 11:55 AM, Kevin Chang notifications@github.com a écrit :

Thank you for your contribution. However, I don't see any syntax highlighting differences between master and your branch. Some solidity files are highlighted, while others are not. Is this an issue with the library? or does it take some time to show up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FourthState/plasma-mvp-rootchain/pull/37#issuecomment-385593385, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH9Opa178HOulzD8b9KibeK0xRK750Oks5tt9yUgaJpZM4TsLJ2 .

colin-axner commented 6 years ago

As described in the issue you linked, it seems adding a space to the non-highlighted .sol files will make them highlighted. It would be great if you could fix those files. Thanks again!

colin-axner commented 6 years ago

Adding a single space after the first line in a file or on the second line should work. This commit: was referenced in the issue for fixing this problem