search

FourthState / plasma-mvp-rootchain

smart contract implementation according to the Plasma MVP spec.
Apache License 2.0
79 stars 24 forks source link

Updated README and fixed highlighting issues #38

Closed colin-axner closed 6 years ago

colin-axner commented 6 years ago

Added Fee1, Fee2 to README. Added spaces to fix non-highlighting issues.

AdityaSripal commented 6 years ago

What's the issue with forcing first input to pay fee again?

colin-axner commented 6 years ago

No issue, @hamdiallam wanted me to change it. I don't see a reason not to do Fee1 and Fee2 though.

AdityaSripal commented 6 years ago

It's simpler with just one fee

hamdiallam commented 6 years ago

I think we should have the option of fee1 and fee2 in case two different people want to create a transaction. The most common case will have fee2 zero'ed out but having the support in beneficial in my opinion

hamdiallam commented 6 years ago

Can we also include the specific required truffle and solc versions needed to build successfully in the readme

colin-axner commented 6 years ago

I added the spec for truffle solc versions to the contributions page. Seemed redundant to have that in two places. I can add it to both though if that is better