Deposit challenge: Check that transaction, handed in for deposit-challenge, is actually spending the deposit

FourthState / plasma-mvp-rootchain

smart contract implementation according to the Plasma MVP spec.

Apache License 2.0

79 stars 24 forks source link

Deposit challenge: Check that transaction, handed in for deposit-challenge, is actually spending the deposit #63

Closed josojo closed 6 years ago

josojo commented 6 years ago

https://github.com/FourthState/plasma-mvp-rootchain/blob/b000573b67dd4e071e6a7259da7ec8f51abb4715/contracts/rootchain/RootChain.sol#L236

I think the check that the transaction, handed in for a deposit-challenge, is actually spending deposit is missing. Currently, only the owner is double checked, but this should not be enough

hamdiallam commented 6 years ago

ah yes! thanks for pointing that out. Will push a fix + tests super soon.

Thanks again!