FourthState / plasma-mvp-rootchain

smart contract implementation according to the Plasma MVP spec.
Apache License 2.0
79 stars 24 forks source link

Hamdi/challenge vulnerability #68

Closed hamdiallam closed 6 years ago

hamdiallam commented 6 years ago

Ensure that the txBytes used to challenge both deposits/transactions are direct spends of the exiting transaction. Using the grandchild transaction will not work because the confirm signature needs to sign over the spending the transaction.

No tests as this is a simple require statement.

Fixes #63

Changed fastforward helper in the test removing the strict bound. The difference in time between the mined block and block before the fastfoward only needs to be atleast time or bigger

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 396


Totals Coverage Status
Change from base Build 392: 0.05%
Covered Lines: 207
Relevant Lines: 217

💛 - Coveralls