search

FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

Hamdi/datastore #170

Closed hamdiallam closed 5 years ago

hamdiallam commented 5 years ago

Single data store for the application. DataStore

  1. Merge BlockStore and OutputStore into a single DataStore. resolves #168
  2. Merge queriers into a single querier mounted under custom/data/...
  3. Remove store/query.BlocksResp. It's an extra unnecessary struct and now plasma.Block includes the block height

168

codecov-io commented 5 years ago

Codecov Report

Merging #170 into develop will decrease coverage by 6.08%. The diff coverage is 40.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    58.67%   52.58%   -6.09%     
===========================================
  Files           27       28       +1     
  Lines         1176     1314     +138     
===========================================
+ Hits           690      691       +1     
- Misses         377      516     +139     
+ Partials       109      107       -2
Impacted Files Coverage Δ
store/querier.go 0% <0%> (ø)
handlers/depositHandler.go 77.77% <100%> (ø) :arrow_up:
store/keys.go 100% <100%> (ø) :arrow_up:
plasma/block.go 100% <100%> (ø) :arrow_up:
handlers/anteHandler.go 71.57% <100%> (ø) :arrow_up:
eth/plasma.go 53.62% <100%> (ø) :arrow_up:
store/errors.go 66.66% <50%> (-33.34%) :arrow_down:
store/datastore.go 70.58% <70.58%> (ø)
handlers/spendMsgHandler.go 73.33% <85.71%> (ø) :arrow_up:
store/outputs.go 68.06% <86.66%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f89d6d...124fe69. Read the comment docs.