FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

Hamdi/client #171

Closed hamdiallam closed 4 years ago

hamdiallam commented 5 years ago
  1. Introduce a new client module

    • client query methods to enable code reuse between the rest handlers and cli commands. resolves #164
  2. Introduce tx, output, and height handlers/queriers for the rest-server

TODO: test cli/rest commands with these new changes.

codecov-io commented 5 years ago

Codecov Report

Merging #171 into develop will decrease coverage by 0.83%. The diff coverage is 12.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
- Coverage    52.58%   51.75%   -0.84%     
===========================================
  Files           28       28              
  Lines         1314     1314              
===========================================
- Hits           691      680      -11     
- Misses         516      529      +13     
+ Partials       107      105       -2
Impacted Files Coverage Δ
store/outputs.go 68.06% <ø> (ø) :arrow_up:
plasma/position.go 61.11% <ø> (-0.21%) :arrow_down:
store/querier.go 0% <0%> (ø) :arrow_up:
utils/utils.go 100% <100%> (ø) :arrow_up:
plasma/transaction.go 51.49% <20%> (-0.82%) :arrow_down:
eth/main.go 43.33% <0%> (-6.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06ed0a2...77fba61. Read the comment docs.

colin-axner commented 4 years ago

@hamdiallam if you have time to fix the merge conflicts, I'm fine including this in 1.0

hamdiallam commented 4 years ago

@hamdiallam if you have time to fix the merge conflicts, I'm fine including this in 1.0

I'm going to fix the merge conflicts. Not heavy