search

FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

some godoc and set the root dir in the server context #178

Closed hamdiallam closed 4 years ago

hamdiallam commented 4 years ago

Fixes #174

The server context should have it's root directory set. Otherwise ctx.Config.RootDir is an empty string causing the bug.

As this bug pertains to the version command, also adding fixes to make sure it is working properly.

Some small godoc fixes as well

hamdiallam commented 4 years ago

Added in the version (pulled from most recent tag found). Should plasmacli be using the same version cmd?

codecov-io commented 4 years ago

Codecov Report

Merging #178 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #178   +/-   ##
========================================
  Coverage    51.75%   51.75%           
========================================
  Files           28       28           
  Lines         1314     1314           
========================================
  Hits           680      680           
  Misses         529      529           
  Partials       105      105

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6274e7c...bae93dd. Read the comment docs.

hamdiallam commented 4 years ago

Deplayed merging this as plasmacli version using the cosmos version command is not registering the --long flag when applied.

However works fine with plasmad