search

FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

[WIP] Add broadcast confirm sig logic #188

Open wesgraham opened 4 years ago

wesgraham commented 4 years ago

(Fixes #148)

Adds the ability to broadcast confirm signatures without spending inputs. Requesting feedback on signature requirements, confirmSigMsg struct, and information to be stored in datastore. Tests pending.

wesgraham commented 4 years ago

Applying above changes. Also removing ability to broadcast arbitrary confirm sigs via flags for now as there is no natural mechanism for validating such signatures

codecov-io commented 4 years ago

Codecov Report

Merging #188 into develop will decrease coverage by 2.58%. The diff coverage is 2.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
- Coverage    52.02%   49.44%   -2.59%     
===========================================
  Files           28       30       +2     
  Lines         1359     1430      +71     
===========================================
  Hits           707      707              
- Misses         538      609      +71     
  Partials       114      114
Impacted Files Coverage Δ
handlers/confirmSigHandler.go 0.00% <0.00%> (ø)
msgs/confirmSigMsg.go 0.00% <0.00%> (ø)
msgs/errors.go 33.33% <0.00%> (-16.67%) :arrow_down:
handlers/anteHandler.go 53.12% <5.71%> (-18.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfea376...c828a0d. Read the comment docs.