search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

Properly check for internet #240

Closed GalaxyNote10 closed 1 year ago

GalaxyNote10 commented 1 year ago

The latest Version 0.6.8 has the change "Properly check for internet" This is done by opening a connection to connectivitycheck.gstatic.com/generate_204 This will fail on my mobile. I am not allowing connections to this URL (or any google at all). Would it be possible to make the connectivitycheck address changeable? like "settings put global captive_portal_https_url "

androidacy-user commented 1 year ago

The latest Version 0.6.8 has the change "Properly check for internet" This is done by opening a connection to connectivitycheck.gstatic.com/generate_204 This will fail on my mobile. I am not allowing connections to this URL (or any google at all). Would it be possible to make the connectivitycheck address changeable? like "settings put global captive_portal_https_url "

Not planned. We're not going to plan for what's largely an edge case.

FoxMMM is not intended for the hardcore anti Google people. Quite frankly, that you trust this manager but not a simple connection to that URL is ironic.

Sorry, but we're not going to change the current behavior. Nothing's broken so we're not going to fix it.

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 1 year ago

it feels so wrong to exclude people who are on their path to degoogle. on latest version, the default repo is connecting to github and i see absolutely no reason to connect to google. as for the counter argument, i can check the module's code while i can't know what google does with my data

Not planned. We're not going to plan for what's largely an edge case.

FoxMMM is not intended for the hardcore anti Google people. Quite frankly, that you trust this manager but not a simple connection to that URL is ironic.

Sorry, but we're not going to change the current behavior. Nothing's broken so we're not going to fix it.

androidacy-user commented 1 year ago

We don't send any data to Google. Heck, we don't even set an user agent so the absolute most they get is an IP address.

Android pings this URL on default configurations regularly. It's a sane URL that 99% of users should be able to access with an internet connection.

FoxMMM was and will never be geared towards the no Google crowd - even if we generally avoid proprietary Google dependencies and ensure our decisions are generally user centric.

I recommend you use the default magisk manager if you really can't trust us. I have nothing more to say on this matter.

Good day.