search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

Add empty sentry dsn to sentryless #261

Closed linsui closed 1 year ago

linsui commented 1 year ago

Fix https://github.com/Fox2Code/FoxMagiskModuleManager/issues/260

The dsn must be set else the app crashes.

androidacy-user commented 1 year ago

We're going to fix it properly because I was told that fdroid builds were just opt in instead of opt out for sentry, not having some complicated setup to remove Sentry, depriving us of vital crash and performance information.

No ETA as it'll hopefully land with the next release.

licaon-kter commented 1 year ago

@androidacy-user Do note that opt-out means the app will be flagged as Tracking ( https://f-droid.org/ro/docs/Anti-Features/#Tracking ) too.

androidacy-user commented 1 year ago

@androidacy-user Do note that opt-out means the app will be flagged as Tracking ( https://f-droid.org/ro/docs/Anti-Features/#Tracking ) too.

I really resent that people view sentry as tracking because that is neither it's purpose nor what it does but we can live with that.

androidacy-user commented 1 year ago

Examples of where it would not be applied - any of the above, if the functionality is opt-in (i.e. you are asked before it happens) and disabled by default. Enabling it should then also require informed consent, i.e. requiring a privacy policy similar to GDPR, and avoid collecting personal data (PII) as far as possible.

If I'm understanding that paragraph correctly, we already have it opt in on fdroid builds and a setup dialogue on first start allowing users to opt in, so it wouldn't apply

licaon-kter commented 1 year ago

Your post above said something else:

fdroid builds were just opt in instead of opt out for sentry, not having some complicated setup to remove Sentry, depriving us of vital crash and performance information

I read it as "fdroid needs to be opt-out too"

Now, if the user is asked at start to choose, then yes, it would not apply,

androidacy-user commented 1 year ago

Your post above said something else:

fdroid builds were just opt in instead of opt out for sentry, not having some complicated setup to remove Sentry, depriving us of vital crash and performance information

I read it as "fdroid needs to be opt-out too"

Now, if the user is asked at start to choose, then yes, it would not apply,

My apologies, it's meant as fdroid users are asked to opt in

linsui commented 1 year ago

Please note that even if the sentry is disabled, it may connect to the server on start. We saw this behavior on another app.

androidacy-user commented 1 year ago

Please note that even if the sentry is disabled, it may connect to the server on start. We saw this behavior on another app.

If they don't set auto init to false then that's expected behavior.

Fox2Code commented 1 year ago

The sentry library shouldn't even be in the apk when the sentryless source is used.

androidacy-user commented 1 year ago

The sentry library shouldn't even be in the apk when the sentryless source is used.

We're reworking it because I was misinformed about how sentry was handled in the fdroid builds. I'm reworking it so it's opt in like I was told it was, not completely removed.

androidacy-user commented 1 year ago

Nonetheless it's already fixed in master, it's going to be released with the next release