Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

Buttons "Install", "Uninstall", "Description", etc. #274

Closed giving-sesame closed 1 year ago

giving-sesame commented 1 year ago

Is your feature request related to a problem? Please describe. There are 2 problems:

  1. The mentioned buttons for each module in Light theme are too small, they do not have button view, they are just a text, so it is not easy to tap on them when necessary. Dark and Black themes are okay.
  2. Please remove tapjacking protection or make it optional like in original Magisk manager. I use 3rd party autobrightness application and it is impossbile to tap the module buttons when it is active.

Describe the solution you'd like

  1. Make the module buttons in Light theme to look like buttons in Dark theme, but with light color palette.
  2. Please remove tapjacking protection or make it optional like in original Magisk manager.

Describe alternatives you've considered N/A

Additional context Screenshots for the 1 problem are attached. Screenshot_20230110-214812287 Screenshot_20230110-214852727

androidacy-user commented 1 year ago

Is your feature request related to a problem? Please describe. There are 2 problems:

  1. The mentioned buttons for each module in Light theme are too small, they do not have button view, they are just a text, so it is not easy to tap on them when necessary. Dark and Black themes are okay.
  2. Please remove tapjacking protection or make it optional like in original Magisk manager. I use 3rd party autobrightness application and it is impossbile to tap the module buttons when it is active.

Describe the solution you'd like

  1. Make the module buttons in Light theme to look like buttons in Dark theme, but with light color palette.
  2. Please remove tapjacking protection or make it optional like in original Magisk manager.

Describe alternatives you've considered N/A

Additional context Screenshots for the 1 problem are attached. Screenshot_20230110-214812287 Screenshot_20230110-214852727

Disabling tapjack protection is inherently a security risk as any app then can fake input on FoxMMM.

And I'm not quite sure what you mean by the first, buttons look like and are buttons in any theme.

giving-sesame commented 1 year ago

Disabling tapjack protection is inherently a security risk as any app then can fake input on FoxMMM.

Could you make it an option?

And I'm not quite sure what you mean by the first, buttons look like and are buttons in any theme.

Please look at my screenshots. I doubt light theme buttons look like buttons.

Fox2Code commented 1 year ago

"Disabling tapjack protection is inherently a security risk", well yes but root is also a risk, adding an option to disable it would be cool.

Some peoples have visibility issues, and I already found legitimate user needing accessibility services to use FoxMMM.

@androidacy-user if you could add an option it would be really nice of you to do that.

androidacy-user commented 1 year ago

"Disabling tapjack protection is inherently a security risk", well yes but root is also a risk, adding an option to disable it would be cool.

Some peoples have visibility issues, and I already found legitimate user needing accessibility services to use FoxMMM.

@androidacy-user if you could add an option it would be really nice of you to do that.

Magisk does not actually use android's native tapjack protection, rather it uses a countdown which would be bad UX for us to use.

The unfortunate part here is afaik the native protection cannot be toggled at runtime - and for every legitimate accessibility service, there's another two malicious ones, and we offer quite the attractive attack point in FoxMMM.

I despise the root is a security risk argument as well. Root is a tool, that doesn't mean we have to allow it to be an attack vector.

androidacy-user commented 1 year ago

Also tapjack protection only prevents the button/input from being interacted with if something is obscuring it - not entirely blocks accessibility, so this is a non issue in most cases anyway.

giving-sesame commented 1 year ago

OK, forget about tapjack protection. I can remove it in APK Editor in a minute, once after each update of ModuleManager, so I will use this way.

I think more users would be interested in button like view of the buttons in light theme, as it is demonstrated in the screenshots in the first message of the topic. What about it?

androidacy-user commented 1 year ago

Cannot reproduce that particular one:

Screenshot of light theme in 1.1 ![Screenshot_20230117-085716](https://user-images.githubusercontent.com/45006100/212917783-6aec28c4-ea23-41bf-ba27-36bd175864cf.png)
giving-sesame commented 1 year ago

Cannot reproduce that particular one: Screenshot of light theme in 1.1

Just open Fox's Magisk Module Manager and you get it. You have to set the light theme: go to the settings and select light theme in section Apperance.

androidacy-user commented 1 year ago

Cannot reproduce that particular one: Screenshot of light theme in 1.1

Just open Fox's Magisk Module Manager and you get it. You have to set the light theme: go to the settings and select light theme in section Apperance.

I literally had the light theme set, please look at the attached screenshot

giving-sesame commented 1 year ago

I'm sorry, but you missed the screenshot

androidacy-user commented 1 year ago

I'm afraid I don't understand what you are trying to say. I can't reproduce, I attached a screenshot I just took from my own device on 1.1 of FoxMMM. I don't know what to tell you.

giving-sesame commented 1 year ago

I mean that you forgot to attach a screenshot you just took from your own device

androidacy-user commented 1 year ago

Uh I didn't? Have you, uhm, tried clicking on the little arrow?

giving-sesame commented 1 year ago

I'm sorry, I thought you attached the screenshot to the message where you texted "please look at the attached screenshot"

I have absolutely another picture. I'll try to reinstall the application, maybe it helps.

giving-sesame commented 1 year ago

Nothing works for me. Buttons keep look like not buttons. Well, if I'm alone with this problem, let it be.

Shrtej commented 1 year ago

You are not alone

giving-sesame commented 1 year ago

Looks much better after update to v2.0.1