search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

Support Individual GitHub Pages #282

Closed raulvasquez closed 1 year ago

raulvasquez commented 1 year ago

Is your feature request related to a problem? Please describe. There are a handful of modules or forks of existing modules that are downloaded and installed manually. For instance, app systemizer is stuck at 17.3.1, but doesn't support Android 13 so I installed this fork https://github.com/KreAch3R/terminal_systemizer

The app has no way of referencing the original install location, or checking updates.

Describe the solution you'd like A simple way to save links to supported sources, for reference and installing updates (eg. GitHub.com, gitlab, etc). Ideally with local release or commit tracking, but even just a way to save or tag the original install location would be useful.

For version tracking I imagine if there is a release page it would easiest https://github.com/programminghoch10/ViPER4AndroidRepackaged/releases just download the file when a new release is pushed or the commit changes.

I'm the case of the systemizer fork https://github.com/KreAch3R/terminal_systemizer it does not have a release page, but you are able to download a zip by modifying the URL to https://github.com/KreAch3R/terminal_systemizer/zipball/master

The zip downloaded will include the latest commit in the zip name, but the zip will need to be modified to remove the parent folder and move the files to the root of the zip. Ie. 7z rn repo-commit.zip repo/* * so that is compatible to be installed by magisk.

androidacy-user commented 1 year ago

FoxMMM already supports custom modules.json/repo sources. I believe that just about covers this, but adding single GitHub repo support seems unnecessary.

raulvasquez commented 1 year ago

FoxMMM already supports custom modules.json/repo sources. I believe that just about covers this, but adding single GitHub repo support seems unnecessary.

the modules.json requires that you host the file somewhere and maintain the contents. The alt repo has a python script that maintains this, but it's not an easy solution for maintaining one off installs where the repo owner doesn't include the requirements. Being able to save, track and update individual GitHub repos by pasting a link would be a lot simpler than hosting and maintaining a json file for personal. Reading a local json option would be a lot more user friendly.

Even if updating wasn't supported, being able to paste a GitHub url and have the manager download the release or zipball would be nice. Ideally it would save that URL somewhere for future reference.

androidacy-user commented 1 year ago

FoxMMM supports the existing updateJSON standard from magisk already, but we have no intention of adding any other support for individual module updates. It's not worth the code cost for the small, edge case benefits - no offense or anything.