search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

[BUG] download issue #294

Closed toolhas4degrees closed 1 year ago

toolhas4degrees commented 1 year ago

Describe the bug Only stock repos installed. When downloading. It downloads a master unflashable zip. not magisk flashable

To Reproduce Steps to reproduce the behavior:

  1. Download all modules in your repos
  2. See which ones say master when downloaded
  3. Fix the zips to make makisk flashable on your server
  4. Let the community know you fixed this as it's counter productive from a download module standpoint

Expected behavior The dev will fix this error

Screenshots If applicable, add screenshots to help explain your problem.

Device info(please complete the following information):

Additional context Add any other context about the problem here.

Fox2Code commented 1 year ago

I'm mentally weakened, so I won't be able to fix the bug for you, @androidacy-user is kindly managing the app while I cannot do so, so please try to send as many information as you can like screenshots or your issue won't be solved for a long time as I don't expect my health to get better any time soon.

androidacy-user commented 1 year ago

I'm mentally weakened, so I won't be able to fix the bug for you, @androidacy-user is kindly managing the app while I cannot do so, so please try to send as many information as you can like screenshots or your issue won't be solved for a long time as I don't expect my health to get better any time soon.

Not an issue on the app end

Sounds like an issue with the upstream alt Repo as I can confirm the Androidacy repo is fine.

androidacy-user commented 1 year ago

Let's be very clear this is an issue with the alt Repo itself, not the app. The app just downloads the file the repo json instructs it to.

The Androidacy repo, the only repo with control of their servers, doesn't have this issue as it's literally impossible due to infrastructure and architecture designs.

So please, stop throwing accusations around like we just don't care or something. Thanks.

androidacy-user commented 1 year ago

We've worked around this in 0ac2779bb0cb6f616b595548d820791111cf08a1. closing as fixed but fix will ship when v2 does.

I still have the stance this is an upstream issue that should be addressed independently, but since it was not as complicated as it could be due to underlying rework of zip handling, so long as alt repo or any other repo that ships source archives continues to provide them in the expected format, they should work.