Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

ROOT ACCESS BUG #303

Closed LitoHDD closed 1 year ago

LitoHDD commented 1 year ago

In the previous version it worked very well. But in this one, when I install it and give it root permissions, a red banner appears in the modules section saying that root is not detected. If you need logs or more information, do not hesitate to contact me. So for the moment I go back to version v1.1.0

andigenn commented 1 year ago

Same here. Device: Xiaomi Mi 8 Global OS: MIUI 12.0.3 (Rooted) App Version 2.0.1

androidacy-user commented 1 year ago

So far it's exclusive to miui, which would indicate yet another oddity with Xiaomi and their software. Nonetheless we can't reproduce so we can't currently fix any problems that could be causing this.

LitoHDD commented 1 year ago

Hasta ahora es exclusivo de miui, lo que indicaría otra rareza con Xiaomi y su software. No obstante, no podemos reproducir, por lo que actualmente no podemos solucionar ningún problema que pueda estar causando esto.

I don't use MIUI I use a custom rom as mentioned in the first report

VSeryi commented 1 year ago

Same here. Device: Oneplus 7T OS: YAAP 13-Tripoli-hotdogb-20230426 (Rooted - Magisk 26.1) App Version 2.0.1

Attached logs from a clean install. logs (1).txt

28Black commented 1 year ago

Same for me as well, will return meanwhile to the previous working version from december.

Device: OnePlus 6 OS: Jaguar ROM (Android 11, GrapheneOS / LineageOS based; Magisk 26.1) App Version: 2.0.1

androidacy-user commented 1 year ago

Same here. Device: Oneplus 7T OS: YAAP 13-Tripoli-hotdogb-20230426 (Rooted - Magisk 26.1) App Version 2.0.1

Error is unrelated and not fatal.

ghost commented 1 year ago

Same happens here In previous versions it works fine

Device: Xiaomi Redmi Note 9S OS: Pixel Experience (Android 13, Magisk 26100) PixelExperience_Plus_miatoll-13.0-20230402-1037-OFFICIAL logs.txt

Qattos commented 1 year ago

Same thing for me. Worked as it should on previous versions. Device: Xperia XZ OS: Latest stock ROM 8.0 (2018) (rooted with Magisk)

androidacy-user commented 1 year ago

Please do not spam the comments with "me too" style comments.

Instead, hit the 👍🏾 on the original comment. Thanks.

androidacy-user commented 1 year ago

@28Black @VSeryi @andigenn @arikyo07 whoever else was having the issue, does this build work any better?

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4815009696

If not, please share the logs from settings -> save logs and share

henosch commented 1 year ago

The debug Version get root Access.

Qattos commented 1 year ago

Unfortunately the debug version still can't use root access despite asking for it.

Here's my Log

andigenn commented 1 year ago

In my case too the debug version still can't use root access despite asking for it. Here's my logs.txt

IZ2QDH commented 1 year ago

Tested both version 2.0.1 and debug version. Issue reproduced. Device: Poco F1 OS: LineageOS 20.0 Android Version: 13 Lygisk 26.1 Debug version logs here

abun880007 commented 1 year ago

Same issue here Device Pixel 7 Pro OS: Android 14 Beta 1.1 Magisk Delta Canary 25210

VSeryi commented 1 year ago

@28Black @VSeryi @andigenn @arikyo07 whoever else was having the issue, does this build work any better?

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4815009696

If not, please share the logs from settings -> save logs and share

Same error.

Debug logs: logs (2).txt

androidacy-user commented 1 year ago

Any luck with this one?

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4819719293

IZ2QDH commented 1 year ago

Any luck with this one?

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4819719293

Nope for me, granted root permission but app says it's denied Logs here

andigenn commented 1 year ago

Unfortunately still no luck. logs (1).txt

osm0sis commented 1 year ago

I have the issue on my Nexus 7 2013 (flo) running Lineage 20, but not on my OnePlus 9 Pro (lemonadep) running Lineage 20. Both have Magisk 26101 and same modules.

flo is arm while lemonadep is arm64, in case that's a factor here. I'll grab logs from flo and add them shortly.

Edit:

logs.txt

Skaynod commented 1 year ago

I accepted Root permission but on the app it says it was denied logs.txt

androidacy-user commented 1 year ago

If people don't stop spamming with "me too", I'm locking this issue.

If you want to provide additional logs/details we don't have yet - fine. But don't comment saying you have the issue too, hit "👍" on the original comment instead.

Thanks.

androidacy-user commented 1 year ago

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4826124597

Another build to test

androidacy-user commented 1 year ago

I have the issue on my Nexus 7 2013 (flo) running Lineage 20, but not on my OnePlus 9 Pro (lemonadep) running Lineage 20. Both have Magisk 26101 and same modules.

flo is arm while lemonadep is arm64, in case that's a factor here. I'll grab logs from flo and add them shortly.

Edit:

logs.txt

TIL Asus made the Nexus 7

Anyway, any chance you could give the build I linked above a whirl? Trying to work around a strange issue or something with libsu - it seems to be falsely reporting no root access for some users.

andigenn commented 1 year ago

On my MI 8 the issue still persists. logs.txt

IZ2QDH commented 1 year ago

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4826124597

Another build to test

issue still present Logs HERE

zgfg commented 1 year ago

I have two Xiaomi phones, one with MIUI 12.5 / Android 11 and another with MIUI 13 / Android 12

On both phones root is properly granted - I will attach screenshots captured when starting Fox MMM, popping up that root was granted

And indeed, I can disable and uninstall modules (would not work without root)

But when I try to install ANY module, Fox MMM crashes for me. On both my phones, for ANY module - even those modules that I already have installed (ie, nothing wrong with the modules)

I just sent you two crash reports from inside the Fox MMM app (fgmicro@gmail.com)

IMG_20230428_205109 Screenshot_2023-04-28-20-53-18-004_com fox2code mmm IMG_20230428_210342

androidacy-user commented 1 year ago

I have two Xiaomi phones, one with MIUI 12.5 / Android 11 and another with MIUI 13 / Android 12

On both phones root is properly granted - I will attach screenshots captured when starting Fox MMM, popping up that root was granted

And indeed, I can disable and uninstall modules (would not work without root)

But when I try to install ANY module, Fox MMM crashes for me. On both my phones, for ANY module - even those modules that I already have installed (ie, nothing wrong with the modules)

I just sent you two crash reports from inside the Fox MMM app (fgmicro@gmail.com)

IMG_20230428_205109 Screenshot_2023-04-28-20-53-18-004_com fox2code mmm IMG_20230428_210342

Separate bug we're already tracking and should be fixed if you install the last successfully built actions build

androidacy-user commented 1 year ago

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4836183745

Another test build up for y'all. Sorry to keep asking but I don't have access to a device with the issue.

Qattos commented 1 year ago

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4836183745

Another test build up for y'all. Sorry to keep asking but I don't have access to a device with the issue.

Won't even open, immediately crashing on my Xperia XZ (8.0)

ghost commented 1 year ago

When I run the app it crashes immediately.

The person who left the comment above did not provide a log, so I provide it.

Device: Xiaomi Redmi Note 9S OS: Pixel Experience (Android 13, Magisk 26100) PixelExperience_Plus_miatoll-13.0-20230402-1037-OFFICIAL

Crash Log
04-29 13:03:21.516  3154  3154 E AndroidRuntime: Process: com.fox2code.mmm.debug, PID: 3154
04-29 13:03:21.516  3154  3154 E AndroidRuntime: java.lang.ExceptionInInitializerError
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at java.lang.Class.newInstance(Native Method)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.AppComponentFactory.instantiateApplication(AppComponentFactory.java:76)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at androidx.core.app.CoreComponentFactory.instantiateApplication(CoreComponentFactory.java:52)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.Instrumentation.newApplication(Instrumentation.java:1245)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1458)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1395)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6751)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2130)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:106)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.os.Looper.loopOnce(Looper.java:201)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:288)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at android.app.ActivityThread.main(ActivityThread.java:7925)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at java.lang.reflect.Method.invoke(Native Method)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942)
04-29 13:03:21.516  3154  3154 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.Context com.fox2code.mmm.MainApplication.getApplicationContext()' on a null object reference
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    at com.fox2code.mmm.MainApplication.<clinit>(MainApplication.java:109)
04-29 13:03:21.516  3154  3154 E AndroidRuntime:    ... 16 more
androidacy-user commented 1 year ago

When I run the app it crashes immediately.

The person who left the comment above did not provide a log, so I provide it.

Device: Xiaomi Redmi Note 9S OS: Pixel Experience (Android 13, Magisk 26100) PixelExperience_Plus_miatoll-13.0-20230402-1037-OFFICIAL

Crash Log

Thanks, but already fixed. As soon as the most recent actions build finishes, I'll need it tested again.

androidacy-user commented 1 year ago

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4836804915 if y'all would

ghost commented 1 year ago

Unfortunately, it doesn't work yet.

Device: Xiaomi Redmi Note 9S OS: Pixel Experience (Android 13, Magisk 26100) PixelExperience_Plus_miatoll-13.0-20230402-1037-OFFICIAL

Here is my log. logs (1).txt

andigenn commented 1 year ago

It doesn't work yet. My logs.txt

androidacy-user commented 1 year ago

It doesn't work yet. My logs.txt

as strange as it sounds, judging by logs we're making progress

osm0sis commented 1 year ago

Would checking out another open source root app project be helpful? I know AdAway has been pretty up-to-date on libsu, and it doesn't seem to have any issues detecting or requesting root on any of my devices: https://github.com/AdAway/AdAway

androidacy-user commented 1 year ago

Would checking out another open source root app project be helpful? I know AdAway has been pretty up-to-date on libsu, and it doesn't seem to have any issues detecting or requesting root on any of my devices: https://github.com/AdAway/AdAway

Just got off work after a few days so I'll edit new logs from latest CI into this in a little bit. 👍

The original root issue was actually fixed in the last build I linked. libsu seems to be expecting us to open a shell proper before letting us know we have root, and would falsely return false or null before we did. Bad design IMHO.

The current issue is a failure to detect magisk's path (which we rely heavily on so we treat not being able to get it as essentially not being rooted). The latest Actions build which I'll link shortly tries to address that.

androidacy-user commented 1 year ago

Again, those who are willing

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4839735163

VSeryi commented 1 year ago

Again, those who are willing

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4839735163

:S Its still not working

logs (5).txt

PS. Thanks for your work!

androidacy-user commented 1 year ago

Yet another yet another

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4841982502

ghost commented 1 year ago

It works fine!!


差出人: Androidacy Service Account @.> 送信日•r: 2023年4月30日 12:00 宛先: Fox2Code/FoxMagiskModuleManager @.> CC: AriKyo KaneDa(金田 •s‚b) @.>; Mention @.> 件名: Re: [Fox2Code/FoxMagiskModuleManager] ROOT ACCESS BUG (Issue #303)

Yet another yet another

https://github.com/Fox2Code/FoxMagiskModuleManager/actions/runs/4841982502

― Reply to this email directly, view it on GitHubhttps://github.com/Fox2Code/FoxMagiskModuleManager/issues/303#issuecomment-1528926357, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF35RNDWZR2ECWFWSL2UHTDXDXITBANCNFSM6AAAAAAXM6MIGM. You are receiving this because you were mentioned.Message ID: @.***>

androidacy-user commented 1 year ago

Unfortunately we'll now have to look for another way to fix ReVanced installation. Closing this issue as it itself is resolved.

andigenn commented 1 year ago

It works fine! Thanks for your work!

osm0sis commented 1 year ago

Can confirm working well on my old Nexus 7 2013 with the latest arm CI build. 🎉