search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

[BUG] Update crash #305

Closed Z-Siqi closed 1 year ago

Z-Siqi commented 1 year ago

Describe the bug Update app from 1.1.0 to 2.0.1 will lead to app cannot work (nothing shows when opened app). But clear the app data can fix it.

To Reproduce Steps to reproduce the behavior:

  1. Install 1.1.0 arm64-v8a
  2. Finish first time setup
  3. Update to 2.0.1 arm64-v8a
  4. See error

Screenshots Just a white screen.

Device info(please complete the following information):

androidacy-user commented 1 year ago

Known and unfortunately intended behavior. Please review the changelog for more information.

LeeBinder commented 1 year ago

also see my post with how it got it working here.

f000bar commented 1 year ago

Re: https://github.com/Fox2Code/FoxMagiskModuleManager/issues/310#issuecomment-1527468012

a very attractive attack vector and an unfortunate side effect of encrypting shared preferences so that malicious modules can't manipulate them is the app

That's super useful context. Thanks for sharing. That also wasn't clear from the release notes - all it said was "now encrypted for additional security".

I haven't thought deeply enough about the security holes myself, so I'm sure I'm missing the underlying concerns. I'll trust that you have, and I appreciate your attention to it.

To be clear: I've never asked you to reverse the decision, nor do I think you should. I'd just hoped for a self healing/wiping mechanism - which sounds like is acting up anyway. That sounds extremely frustrating.

Thanks for taking the time to hear me out. I appreciate that it's never easy to message things at the right level to satisfy everyone.

I've also just installed the most recent version (2.0.2) after having reinstalled 1.1.0 (no root issue), and it this time it self-corrected the settings - I had to reconfigure (as expected) but much clearer than the crash loop. So thanks for the fix!