search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

Add Keep System font option #311

Closed xerta555 closed 1 year ago

xerta555 commented 1 year ago

Is your feature request related to a problem? Please describe. With the last version, a specific font is forced

Describe the solution you'd like Please add an option in the settings page to keep the system font in app, with an warning if you want.

Describe alternatives you've considered Stop to forcing a specific font in the app or add an option to let the final choice to the user.

Thanks in advance.

androidacy-user commented 1 year ago

We chose the Inter font for its high readability and the fact it works well with a wide range of languages, something we can't guarantee with an externally controlled font.

While we appreciate that a handful of users may prefer their own font, such an implementation would require us to rewrite our themes and potentially require us to maintain twice as many as well as an implementation to handle switching them on demand, leading to complexity and technical debt.

xerta555 commented 1 year ago

such an implementation would require us to rewrite our themes and potentially require us to maintain twice as many as well as an implementation to handle switching them on demand

Why it would require that ?

androidacy-user commented 1 year ago

such an implementation would require us to rewrite our themes and potentially require us to maintain twice as many as well as an implementation to handle switching them on demand

Why it would require that ?

Because the font in use is defined in our app theme

xerta555 commented 1 year ago

Because the font in use is defined in our app theme

Okay, and no way to reverse back this decision?