search

Fox2Code / FoxMagiskModuleManager

A module manager for Magisk because the official app dropped support for it
GNU Lesser General Public License v3.0
2.19k stars 131 forks source link

[BUG] Module's name can be shown in different font size #314

Closed giving-sesame closed 1 year ago

giving-sesame commented 1 year ago

Describe the bug When I launch FoxMMM, some modules' names are shown in smaller font size. When I exit and then launch FoxMMM again, those modules are shown in normal font size, but now other modules' names are smaller. This picture changes each time I launch the application.

To Reproduce Just launch the application and check the list of modules. Some of them have names in smaller size.

Expected behavior All modules' names are of the same size.

Screenshots I added a gif explaining the problem. It contains 2 screenshots of 2 different launched of FoxMMM. Untitled

Device info(please complete the following information):

androidacy-user commented 1 year ago

Will investigate, but cannot reproduce and first report so far.

Fox2Code commented 1 year ago

It's because I made the system in a way that is not easy for @androidacy-user to maintain, prob because the view doesn't get reset properly. @androidacy-user make sure to always set every value in the update function of ModuleViewAdapter even if you need to set it to it's already initial value.

Fox2Code commented 1 year ago

TL;DR It's my fault for making messy system that is hard to maintain.

androidacy-user commented 1 year ago

If you can still reproduce against v2.0.2, please open an issue at https://github.com/Androidacy/MagiskModuleManager

giving-sesame commented 1 year ago

Yes, the bug still exists in 2.0.2. Will open an issue there