FoxAhead / Civ2-UI-Additions

Civilization II User Interface Additions
MIT License
53 stars 3 forks source link

Unable to Respond During Negotiations with AI #11

Closed aryker closed 3 years ago

aryker commented 3 years ago

Hey there,

First off, this patch is amazing! Thanks for all your hard work!

I started a new game with this patch applied yesterday, and after a while I noticed that whenever I am negotiating with an AI, I am never taken to the dialog box titled "You Respond..." with options to ask for tribute, propose trades, etc. This happens whether the negotiation was initiated by myself or the AI. I have tried to do some debugging, but my Pascal-fu is weak and I am not familiar with the memory addresses used by the game (e.g. the WriteMemory call in C2PatchHostileAi). I am happy to help troubleshoot further; just let me know what you need.

The typical dialog path seems to be: Send Emissary -> "Greetings from..." -> [Standard threat/request for tech made by AI] -> "Pleased to speak to you..." -> [End Dialog]

Thanks!

aryker commented 3 years ago

Another thing I have noticed, perhaps on a related note, is that moving a Spy into an enemy city does not initiate the typical dialog box that allows you to inspect, sabotage, etc.

FoxAhead commented 3 years ago

Hi! It would be easier if I had a save file and steps to reproduce.

aryker commented 3 years ago

No problem! Save file is in the attached zip folder, since GitHub won't let me upload a .sav file. al_b2460.zip

To reproduce the negotiation issue:

  1. Click Advisors -> Foreign Minister (or press F3)
  2. Select any of the three civilizations on the list and click "Send Emissary"
  3. Select "Never! The xxx are our friends." (or whatever equivalent option is presented)
  4. Opt not to enter a military alliance if they propose one.
  5. Click OK when they say they're happy to talk to you.
  6. No response dialog will appear, and the conversation will end.

Te reproduce the Spy dialog issue:

  1. Move the Spy in Corinth to the yellow (Spanish) city of Salamanca (she should be the active unit when you load the save).
  2. No dialog box will appear.

Let me know if there's anything else I can do to help. Thanks again!

FoxAhead commented 3 years ago

image image image

aryker commented 3 years ago

Interesting... My selected options are a bit different. These are the ones I had selected up until this point:

image

I tried changing mine to match yours, and still got no dialog. I will try to patch a fresh install and let you know what happens.

FoxAhead commented 3 years ago

The same is with negotiations. Did you test it without launcher? If issue reproduces in vanilla game, then maybe it is something with your system config? Do you have multiple monitors. Maybe popup appears somewhere else. Or maybe it is hidden behind other windows. Try to move them around. Or choose from menu View - Arrange Windows. BTW it is not a patcher. It is a launcher that patches in-memory. So if you run civ2.exe directly you should get vanilla game (unless it is patched by some other patches).

aryker commented 3 years ago

I get the same result with the vanilla game, so it must be something to do with my system. I'm currently running on a laptop connected to two additional monitors via a Dell Thunderbolt Dock. I will try on a different system later today. Thanks for taking the time to test and clarify, and apologies for taking up your time!

FoxAhead commented 3 years ago

image You can use Microsoft Spy++ tool from VS to inspect process' windows and find missing popup. Just check it coordinates (rectangle). Maybe it is really off screen.