search

FoxComm / highlander

Because there can only be one
MIT License
9 stars 3 forks source link

/coupons/new. Form field error message at "Length" counter breaks layout. #1479

Open alexanderfc opened 7 years ago

alexanderfc commented 7 years ago

Preconditions:

  1. Any coupon type promo.

Steps to reproduce:

  1. Sign in at /admin as an admin user
  2. Navigate to promotions
  3. Open any coupon type promo
  4. Switch to "Coupons" tab
  5. Click "+Coupon"
  6. Select "Bulk generate coupon codes"
  7. Increase "Quantity", e.g. to 20
  8. Look at the position of "Length" counter once error message appears

Actual result: "Length" counter is shifted to the next line. Expected result: "Length" counter remains on the same line with "Code Prefix" and "Quantity".

Screenshot:

![2017-04-16 17 40 27](https://cloud.githubusercontent.com/assets/18313903/25072003/3b5af91a-22cd-11e7-9bbb-4c4c2e4609fe.png)
alexanderfc commented 7 years ago

@bswineford @mourningking could someone of you check the expected position of that error message and say if it's okay if it will be moved down? Also, in this case, highlighting the "Length" counter with red would be good. What do you think?

bagratinho commented 7 years ago

https://github.com/FoxComm/highlander/pull/2331