FoxComm / highlander

Because there can only be one
MIT License
9 stars 3 forks source link

Ashes styles and layout general bugs. #2049

Open alexanderfc opened 7 years ago

alexanderfc commented 7 years ago
![2017-06-02 17 47 07](https://cloud.githubusercontent.com/assets/18313903/26731174/dab178dc-47bb-11e7-8dd8-d861501c9ff3.png)

![2017-06-02 17 59 45](https://cloud.githubusercontent.com/assets/18313903/26731643/61e856ee-47bd-11e7-9d1c-7d0442672aec.png)

![2017-06-02 17 55 12](https://cloud.githubusercontent.com/assets/18313903/26731524/03b7e954-47bd-11e7-8b10-f22b5fa8ef6f.png)

Video: https://www.dropbox.com/s/3z7t1dapzmuzgrp/highlander_2049-1.mp4?dl=0

![2017-05-23 23 55 07](https://cloud.githubusercontent.com/assets/18313903/26731917/563b36ee-47be-11e7-85c7-55496c0d5731.png)

![2017-06-02 18 08 47](https://cloud.githubusercontent.com/assets/18313903/26731983/9bb684e4-47be-11e7-8615-537177bbeeea.png)

Video: https://www.dropbox.com/s/k416w6c66j9tod8/highlander_2049-2.mp4?dl=0

![2017-06-02 20 08 17](https://cloud.githubusercontent.com/assets/18313903/26736566/5eb44b24-47cf-11e7-9f08-e1e9d758ce34.png)

Video: https://www.dropbox.com/s/aak41f6a1obq9di/highlander_2049-3.mp4?dl=0


![2017-06-02 18 20 54](https://cloud.githubusercontent.com/assets/18313903/26732453/56691968-47c0-11e7-9c81-2e4709dac095.png)

![2017-06-03 23 13 41](https://cloud.githubusercontent.com/assets/18313903/26756756/97fa729e-48b2-11e7-9c95-d98f249c27d7.png)

![2017-06-03 23 27 09](https://cloud.githubusercontent.com/assets/18313903/26756865/8c8d94de-48b4-11e7-8b8d-b40e347d6191.png)

![2017-06-02 18 24 42](https://cloud.githubusercontent.com/assets/18313903/26732693/21d41724-47c1-11e7-8894-1c6562beee68.png)

![2017-06-02 18 27 55](https://cloud.githubusercontent.com/assets/18313903/26732768/6cbd22a8-47c1-11e7-96d3-7bfcd07e2890.png)

![2017-06-03 23 07 43](https://cloud.githubusercontent.com/assets/18313903/26756714/96e87ff0-48b1-11e7-9b1e-b5442218118c.png)

![2017-06-02 18 31 28](https://cloud.githubusercontent.com/assets/18313903/26732868/c0ea88e8-47c1-11e7-8770-8e0cdfd84f01.png)

Video: https://www.dropbox.com/s/o7739h9e44wwqfr/highlander_2049-4.mp4?dl=0


![2017-06-02 20 03 18](https://cloud.githubusercontent.com/assets/18313903/26736433/a9655452-47ce-11e7-8d11-0bd0d873e95d.png)
--- - [ ] MCG. Split "Add Customers" and "Edit Group" buttons.
![2017-06-02 20 04 32](https://cloud.githubusercontent.com/assets/18313903/26736461/ccdf6f1c-47ce-11e7-8c14-b2cf43bb96ab.png)
--- - [ ] GC details page. Blocks with GC details info are shifted.
![2017-06-02 18 11 16](https://cloud.githubusercontent.com/assets/18313903/26732066/f25285c8-47be-11e7-92ed-2ea904ed3eba.png)
--- - [ ] Side nav menu. Scroll bar shouldn't appear if there's nothing to scroll.
![2017-06-02 18 23 05](https://cloud.githubusercontent.com/assets/18313903/26732555/a92a0d6a-47c0-11e7-948b-09b002243861.png)
--- - [ ] Coupon creation. Single code duplication error should be more user friendly and be displayed in UI.
![2017-06-03 23 09 45](https://cloud.githubusercontent.com/assets/18313903/26756723/e91261ce-48b1-11e7-9c3d-61c3891fd8c9.png)
--- - [ ] Taxon value details, add product search. Search icon in the search input field should disappear once input is empty anymore.
![2017-06-03 23 31 08](https://cloud.githubusercontent.com/assets/18313903/26756907/235a6572-48b5-11e7-8d3a-0b9b4dd08ff3.png)
tonypizzicato commented 7 years ago
Sometimes a hard refresh is needed to make bulk issued gift cards appear on the category table as they might not be displayed there after they are issued and user redirected from /gift-cards/new to /gift-cards.

looks like you have no problem on the video, it's just sorted not by date by default. as it's 24 vs 27 gards in the list (number near title). anyway, it's a problem of ES mapping time, not UI bug same for

New taxonomy doesn't appear in side menu.
It just might not appear right after creation. Either hard refresh or other taxonomy creation is needed.
ENCHANCEMENT. Make the list of taxonomies in side menu collapsible.

let's move this one out of here. need mockups

Taxonomy values. Number of the linked products is always 0.

should be fixed here #2083

SKU not associated with the product appears in line_items_search_view.

let's create separate issue is it's a backend problem

 Promo details page. Not user friendly error msg on attempt to create promo with 0% off order offer.

we need to work on error handling approach throughout the system. let's skip it for now

alexanderfc commented 7 years ago

@tonypizzicato

Taxonomy values. Number of the linked products is always 0.

should be fixed here #2083

Looks like #2083 hasn't fixed it. On current stage you can check (taxonomy) Special Diets > (value) Dairy Free - it has 1 linked product, though it's 0 on the values table in Products column.

Agreed with the rest - I'll move mentioned stuff to separate issues. As for the error handling - I'll keep gathering problematic things all around the Ashes. Just tell me when you'll be starting the work around error handling so I could throw that stuff in.

The only question is - are we planning to do something with ES mapping time problems? Not seeing something you've just created or updated is a pretty common thing in Ashes.

alexanderfc commented 7 years ago

@Diokuz

Messaging. bell icon is too small It's still small, just like on the original screenshot. I also have some confusion about how messaging works, but I guess that's a broader topic which we won't touch in this issue and epic in general.

tonypizzicato commented 7 years ago

Looks like #2083 hasn't fixed it.

fixed in #2183

jmataya commented 7 years ago

Looks like the connected issue has been merged. Moving this to done, and @alexanderfc can move back if needed.