search

FoxIO-LLC / ja4

JA4+ is a suite of network fingerprinting standards
https://foxio.io
Other
774 stars 65 forks source link

JA4X for Python crashes with one Extension #114

Closed axmahr closed 1 month ago

axmahr commented 1 month ago

Hi!

The attached pcap file here contains a certificate with only one extension. This crashes the python implementation here: https://github.com/FoxIO-LLC/ja4/blob/9f884cf6f16f4d30ef540ab1ccd1645132a8bb04/python/ja4x.py#L78-L82 x['cert_extensions'] is expected to be a list. However, it is a string when the certificate contains only one extension.

noeltimothy commented 1 month ago

This has been fixed and merged.