The installer does not ask where to install

FoxP / PNG-to-ICO

KISS batch script to easily convert PNG, GIF, BMP, SVG or JPG images to multi-resolution ICO files using ImageMagick.

https://foxp.github.io/PNG-to-ICO/

The Unlicense

185 stars 20 forks source link

The installer does not ask where to install #7

Open Neustradamus opened 8 months ago

Neustradamus commented 8 months ago

Dear @FoxP,

Thanks for your project.

I have a problem, the installer does not ask where I would like to install. I can not to install in default software folder -> Program Files for example. Can you create a good install which permit to select where to install and by default in Program Files ?

Thanks in advance.

FoxP commented 8 months ago

Hello, You can use the portable version : https://github.com/FoxP/PNG-to-ICO/releases/download/v1.0/png_to_ico_portable.zip King regards

Neustradamus commented 8 months ago

It is needed to edit the .nsi to permit the folder install folder choice and have by default the "Program Files" or "Program Files (x86)":

https://github.com/FoxP/PNG-to-ICO/blob/master/png_to_ico.nsi

After, it is needed to create a new release build with 2 installers -> 1 x86 and 1 x64 .exe. You can have one build more with userdata folder too.

FoxP commented 6 months ago

This script is a simple .bat file, not a full-featured software : spending time on the installer / NSI is a little bit "overkill" in my opinion. But anyway, don't hesitate to submit a pull request for this, I'll be happy to merge it. 👍

A single .nsi would be the best option. But to be able to prompt the user to chose his/her own installation directory, you must use a NSIS plugin : https://nsis.sourceforge.io/Docs/nsDialogs/Readme.html Have a look at nsDialogs::SelectFileDialog and nsDialogs::SelectFolderDialog.