Closed Cornelicorn closed 1 year ago
The hardcoded Owner UUID is just a placeholder.
I'm not sure if the Owner UUID should be dynamically associated with every certificate, set once for all custom certificates (statically in sbctl or read from the filesystem as the certificates) or the existing UUID (/usr/share/secureboot/GUID
) should be reused
I think utilizing a custom GUID for this is fine. It makes it easier to make assumptions on when looking at the signature database.
I think utilizing a custom GUID for this is fine. It makes it easier to make assumptions on when looking at the signature database.
Ok, I put in a newly generated UUID (instead of the tpm-eventlog one incremented by 1).
If you want an additional challenge, you could try to write a test for this using the virtual filesystem layer sbctl
has :)
Example: https://github.com/Foxboron/sbctl/blob/master/cmd/sbctl/status_test.go
If you don't have time that is fine as well, but getting more test coverage would be cool.
You mean a test to check that enrolling custom certificates works?
Yep :)
After looking through the testing suite, I don't think that's quite doable for me right now (It's the first time for me to work with go), sorry.
That is fine :) No worries!
I think GitHub still wants a separate approval for the workflow runs, besides the PR review.
Thanks for implementing this :)
Closes #190.