search

Foxboron / sbctl

:computer: :lock: :key: Secure Boot key manager
MIT License
1.35k stars 71 forks source link

Dbx Key Management #236

Closed RiSKeD closed 10 months ago

RiSKeD commented 10 months ago

Enrollment/Rotation/Reset of dbx keys.

Foxboron commented 10 months ago

Thanks!

Foxboron commented 7 months ago

@RiSKeD So, I should have caught this during review but the dbx implementation here doesn't really make sense.

Creating a key and expecting it to be enrolled is not really how we use dbx in UEFI, it should be a revocation list and be specially handled. Currently it's breaking key enrollment for enroll-keys.

I'll need to partially revert this patch, but if you can explain how you are currently using this feature I can try and not break it for your usecase.