Foxboron / sbctl

:computer: :lock: :key: Secure Boot key manager
MIT License
1.35k stars 71 forks source link

only remove entries if they are there #294

Closed hboetes closed 2 months ago

hboetes commented 3 months ago

This fixes a problem on fedora. If this check is not done, removing a kernel will fail and the rpmdb will become corrupt, showing multiple entries. (use: "rpm -e --allmatches" to remove them)

I bet this hack is imperfect, but it sure is a step in the right direction.

Foxboron commented 3 months ago

(you can ignore the CI checks. I need to do some cleanup)

Thanks!

hboetes commented 3 months ago

No worries, I'm used to it.

jeduardo commented 1 month ago

Any idea when we will have a new release with this one?

hboetes commented 1 month ago

That would be nice indeed, on every machine I'm rolling out sbctl I also have to apply this patch or notice kernel uninstalls failing.

Foxboron commented 1 month ago

Yes, I've been down with a fever+busy and as a result been behind on my other FOSS work the past week.

jeduardo commented 1 month ago

Hey @Foxboron no worries, health always comes first! Not sure what's your internal process to cut out a release but if there's anything I can help with let me know!

jeduardo commented 1 month ago

Just got the update in Fedora with the fix though the COPR repo I used. Thanks @Foxboron for merging this and cutting the new release!