search

Foxboron / ssh-tpm-agent

:computer: :key: ssh-agent for TPMs
MIT License
354 stars 20 forks source link

add support for owner password #37

Closed novag closed 5 months ago

novag commented 9 months ago
novag commented 9 months ago

Thanks for the very quick review! Unfortunately, I've only now found the time to address the review.

Foxboron commented 9 months ago

Still missing a test to check that ownerpassword actually works for the key loading. But I can write that up if you dont want to figure out how.

novag commented 7 months ago

Thanks! I will push the test soon. However, this PR is blocked until https://github.com/google/go-tpm/pull/357 is merged.

Foxboron commented 7 months ago

Currently away so won't review this until later this weeks, but why do you need HierarchyChangeAuth for this change?

novag commented 7 months ago

It's required to set an initial owner password for the test. Or is there another way that I am not aware of to initialize the TPM simulator with an owner password?

Foxboron commented 7 months ago

Ah, this makes sense :)

I haven't read the complete TPM spec and stuff I do is very much me learning as a I go. I haven't messed around with owner password so you are probably correct.

novag commented 7 months ago

I haven't read the whole spec either, but I'm pretty sure there's no other command for it. Thanks for your quick reply! :)

Foxboron commented 6 months ago

Please do tell me if the go-tpm patches takes too much time for you. I'd rather have this merged without a test then having it go stale because you are not able to work on the go-tpm patch :)

Foxboron commented 5 months ago

LGTM.

Thanks for working on this :)