Foxlider / FASTER

Full rebuild of Flax's tool for installing and updating Arma 3 server with built in features for managing Steam Workshop mods.
GNU General Public License v3.0
123 stars 34 forks source link

[BUG] Copies all *.bikey in mod folder, including unspecified optionals #151

Closed MildlyInterested closed 4 months ago

MildlyInterested commented 10 months ago

Describe the bug
Have @ace as a deployed mod, copy keys, there is no .bikey files for noactionmenu etc in the servers key folder.

To Reproduce
Steps to reproduce the behaviour:

  1. Deploy ace mod and copy keys profile
  2. Check server key folder, contains optional bikey files

Expected behaviour
Do not copy additional bikey files.

Actual behaviour
Seems like its searching for any bikey file in the mod folder and copies them all over.

Additional context
ACEs optionals structure looks like this: @ace\optionals\@ace_noactionmenu\keys\*.bikey The main key is located here: @ace\keys\*.bikey I suggest limiting how many folders deep the search for .bikey files is, the main key should not be as deep as optionals.

OverlordZorn commented 10 months ago

image-1

OverlordZorn commented 10 months ago

image-4

jupster commented 10 months ago

After spending some time figuing out how this could work. We would still have an issue if someone is needing those compacts but the keys dont get added couse of the changes.

I may look into a better way of getting keys rather then editting what it grabs due to that issue.

MildlyInterested commented 10 months ago

If someone needss these keys they still need to get the client to actually load these PBOs, which is not possible with the official ACE steam mod unless you move folders around manually. Chances of that happening are really low.

If someone want's players to load e.g. ACE_Particles these players will need to subscribe to an ACE_Particles mod, they server can do the same and load the .bikey from there. Bikey in there won't be two folders deep.

jupster commented 10 months ago

If someone want's players to load e.g. ACE_Particles these players will need to subscribe to an ACE_Particles mod, they server can do the same and load the .bikey from there. Bikey in there won't be two folders deep.

That is true didn't think about that.

Okay time to find a way to fix it.

jupster commented 9 months ago

For when i fix this -> https://github.com/Foxlider/FASTER/blob/f4492316393656b8f5fe591d1ed7f2cd1cdf99ad/FASTER/ViewModel/ProfileViewModel.cs#L367C13-L367C13

liamcannon commented 6 months ago

😎 @jupster