[FEAT] Renamed Client/Server headings #165 - Githubissues

Foxlider / FASTER

Full rebuild of Flax's tool for installing and updating Arma 3 server with built in features for managing Steam Workshop mods.

GNU General Public License v3.0

123 stars 34 forks source link

[FEAT] Renamed Client/Server headings #165 #166

Closed liamcannon closed 5 months ago

liamcannon commented 7 months ago

Closes #164

Motivation and Context

Clears confusion for how a mod is loaded on the server
Updated tool tips
Updated Column headers to abbreviations

How Has This Been Tested?

Launch Faster
Open Server profile
Tested on 1.9

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

jupster commented 7 months ago

Changes broke right click drop downs (Ref photo) from Server and Client column.

Check FASTER/Models/ServerProfile.cs, FASTER/ViewModel/ProfileViewModel.cs, FASTER/Views/Profile.xaml & FASTER/Views/Profile.xaml.cs

liamcannon commented 6 months ago

Changes broke right click drop downs (Ref photo) from Server and Client column.

Check FASTER/Models/ServerProfile.cs, FASTER/ViewModel/ProfileViewModel.cs, FASTER/Views/Profile.xaml & FASTER/Views/Profile.xaml.cs

Resolved in recent commit

liamcannon commented 6 months ago

The Wiki will need to get updated once this goes live.

liamcannon commented 6 months ago

Looks like the people have decided

liamcannon commented 6 months ago

I started to add the updated headers w/ the linebreak and implemented it like this. But realized it breaks the right click menu. You guys have any thoughts on a better way to do it?

<DataGridTemplateColumn Width="auto">
     <DataGridTemplateColumn.Header>
         <TextBlock TextWrapping="Wrap">
             <Run Text="SERVER +" />
             <LineBreak />
             <Run Text="CLIENT" />           
         </TextBlock>
     </DataGridTemplateColumn.Header>
     <DataGridTemplateColumn.CellTemplate>
         <DataTemplate DataType="models:ProfileMod">
             <CheckBox IsChecked="{Binding ClientSideChecked, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" HorizontalAlignment="Center"/>
         </DataTemplate>
     </DataGridTemplateColumn.CellTemplate>
 </DataGridTemplateColumn>

I could do something like

public string HeaderText { get; } = "SERVER +" + Environment.NewLine + "CLIENT"; in a utility class or in the view model

liamcannon commented 6 months ago

Current thing on hold is best way to implement the text stacking without breaking right click. Spoke with Jupster a few days ago and they said they'd take a peak. Solution above breaks because its using the text box instead of Header="Server + Client in the DataGridTemplateColumn