Int64 allows NAs while it makes pd.merge more efficient

FoxoTech / methylprep

Python-based preprocessing software for Illumina methylation arrays

MIT License

34 stars 14 forks source link

Int64 allows NAs while it makes pd.merge more efficient #66

Closed adamritter closed 3 years ago

marcmaxson commented 4 years ago

see https://pandas.pydata.org/pandas-docs/stable/user_guide/integer_na.html

this would make the package not work with pre v0.24 versions of pandas, which are still used in many places. so Adam is looking into whether we can have methylprep work with older versions as well

marcmaxson commented 3 years ago

Still holding off on this change, because it requires all users to upgrade dependencies (pandas > v1.0).

But version 1.4+ of methylprep will likely force upgrades of these packages anyway.

marcmaxson commented 3 years ago

This change was implemented in methylcheck version 1.4x, so closing.