feat(notifications): Make init more granular and always complete init - Githubissues

FoxxMD / multi-scrobbler

Scrobble plays from multiple sources to multiple clients

https://foxxmd.github.io/multi-scrobbler

MIT License

425 stars 18 forks source link

feat(notifications): Make init more granular and always complete init #216

Open FoxxMD opened 4 weeks ago

FoxxMD commented 4 weeks ago

Checklist before requesting a review

[x] I have read the contributing guidelines.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Describe your changes

Notifications are not mission critical so its okay if they fail on init because service outage may be transient. Always init notification services and always attempt to push (we catch failures anyway)
Parse more info from notification URL and test simple reachability of host/port to make troubleshooting easier

Issue number and link, if applicable

Fixes #215

github-actions[bot] commented 4 weeks ago

:package: A new release has been made for this pull request.

To play around with this PR, pull an image:

foxxmd/multi-scrobbler:pr-216

Images are available for x86_64 and ARM64.

Latest commit: a04c1f4e413a03e4174b8fa92127851b7c54ba5b