Closed iluvatyr closed 1 year ago
I think it would be best, if there was a container internal mechanism implemented that tries polling again after a defined time
There is! You are looking for maxPollRetries
, maxRequestRetries
, and retryMultiplier
which can be specified for
config.json
using the sourceDefaults
property or spotify.json
) in the data
property.A health check endpoint is a great idea. I don't have time to implement this right now but if you like to give it a go a submit a PR i'd be happy to merge it.
Hello, I see you closed this, but it is not entirely clear to me how to fix this now. First and foremost, I do not know, which values would be appropriate for the above to not happen anymore. Secondly, how is setting this possible in an ENV-Configuration, not using config files? is it even possible?
But thanks for letting me know it is possible to configure it via json configuration files!
If you do not have a lot of time for a health check, I think a get request to a custom URL on a poll stopping or error coming up would already be enough for a lot of things
which values would be appropriate for the above to not happen anymore.
I've recently rewritten the documentation and it now includes a schema explorer for each config file and the general config.json
file. Here is the explorer for the general config (also linked in the docs). The explorer contains descriptions, examples, and a live editor/validator. The sourceDefaults
property is the one you are interested in.
To increase the polling attempts you could have a config.json
file that contains only this:
{
"sourceDefaults": {
"maxRequestRestries": 3,
"maxPollRetries": 12,
"retryMultiplier": 10
}
}
Which will make MS:
# of attempts * 10 seconds
seconds between each polling retry attemptis setting this possible in an ENV-Configuration
No it is not. The ENV based config is for supporting the bare minimum setup for MS.
On the code side I already have to structure all this user data into something equivalent to json (nested objects) so it's much easier to use config files for that input since I can easily validate and parse that complex/nested data. MS already has ~20 ENV variables I have to support alongside the regular config files and I don't plan on adding more if possible.
EDIT: For your specific scenario you must have already setup a config directory since the spotify source has to store its credentials in a file anyway. It should be trivial to create a json file in the same directory.
Hello FoxxMD,
Thank you! I was just finished with my process of converting all the environment variables to jsons when you posted this. The documentation is showing nicely how to format the json files. It worked on first try. I just didnt know exactly what values are appropriate since I do not know the polling mechanism and how it should be for not trying too long but still long enough.
Thank you for showing me some values that I will use.
I was checking my scrobbles and suddenly noticed that many scrobbles of the last days are missing. So I manually checked the logs of the multiscrobber and noticed that it stopped scrobbling tracks from spotify since half a month already. The tracks I played there are therefore lost now.
I think it would be best, if there was a container internal mechanism implemented that tries polling again after a defined time, because there is no way someone wants to constantly check if the scrobbling is still working.
Secondly, it would be great to have an additional email or other notification that can be configured to inform the user that there is an issue regarding something in multi-scrobbler.
Options to inform user about an issue with multi-scrobbler:
Logs are here: