FoxxMD / multi-scrobbler

Scrobble plays from multiple sources to multiple clients
https://foxxmd.github.io/multi-scrobbler
MIT License
346 stars 16 forks source link

Listenbrainz 'playing_now' Support #74

Open ARufenach opened 1 year ago

ARufenach commented 1 year ago

Listenbrainz has a feature that can track live listens using the 'playing_now' type instead of the 'single' type when submitting to the submit-listens endpoint. This would be a nice addition to see what's being listened to at the moment from the Listenbrainz side.

FoxxMD commented 1 year ago

I like this idea and I'd like to expand it a little bit and have a "now playing" in the MS ui for every source it is monitoring as well as notification/webhook functionality. It's already tracking this information in order to determine when to scrobble. Going to work on this for a bit.

ARufenach commented 1 year ago

That sounds like a great extension of the idea. I await the fleshed out update👍

FoxxMD commented 1 year ago

Hey @ARufenach just wanted to let you know progress is being made :)

image

ARufenach commented 1 year ago

Looks great! Can't wait for the update.

FoxxMD commented 1 year ago

@ARufenach you can try MS with now playing support for listenbrainz in the develop branch or foxxmd/multi-scrobbler:develop docker image.

Caveat for how it works:

Additionally, player functionality is now enabled for lastfm sources.

ARufenach commented 1 year ago

Just pulled the latest docker image and the new UI changes look really good, but I'm not getting the 'now playing' notification on the Listenbrainz website like this: image I do get this however if I use the Jellyfin Listenbrainz plugin and bypass MS. Scrobbles are still submitted like normal, just no 'now playing' display.

FoxxMD commented 1 year ago

Ah I think I see...so what you are wanting is:

If this is correct this is not how I interpreted it :sweat_smile: the feature I introduced is for a Listenbrainz Source where MS gets the now_playing notification from LZ and displays it.

I'll need to do some more research to see if sending a now_playing notification affects subsequent scrobbles -- or if LZ scrobbles based on now_playing -- and see about using the play to notify an MS client...

ARufenach commented 1 year ago

Oh that's my bad, I should've been more specific in the initial request. I wasn't even aware that you could have Listenbrainz as a source.

But yes, my request is to have a configured source (in my case Jellyfin) playing a track, have MS monitoring it and send Listenbrainz a now_playing payload such that when you're listening to a track, it displays as 'now playing' on Listenbrainz. Purely a nice-to-have feature. Sorry for the confusion!