FoxxMD / multi-scrobbler

Scrobble plays from multiple sources to multiple clients
https://foxxmd.github.io/multi-scrobbler
MIT License
299 stars 14 forks source link

Error scrobbling songs by Daft Punk from LB to Maloja #94

Closed ghost closed 9 months ago

ghost commented 9 months ago

Using version 0.5.1 of the develop branch (Nodejs). Using version 3.1.5 of maloja.

Listening to any song by Daft Punk results in the artist being scrobbled as multiple artists Daft Punk, Da, and Punk.

For example, listening to the song Instant Crush by Daft Punk and Julian Casablancas.

 {
  "track_metadata": {
    "track_name": "Instant Crush (feat. Julian Casablancas)",
    "artist_name": "Daft Punk",
    "release_name": "Random Access Memories",
    "additional_info": {
      "duration": 338,
      "origin_url": "https://music.youtube.com/watch?v=khnokW3Mw24",
      "submission_client": "Web Scrobbler",
      "music_service_name": "YouTube Music",
      "submission_client_version": "3.1.0",
      "recording_msid": "878c787e-5dd4-42b4-9c2b-1b53baec7e8b"
    },
    "mbid_mapping": {
      "recording_mbid": "dbc0da50-4bc6-4230-9e7b-136b5dc2b31a",
      "recording_name": "Instant Crush",
      "release_mbid": "bbfc83ad-826f-4957-893d-a808105c828b",
      "artists": [
        {
          "artist_mbid": "056e4f3e-d505-4dad-8ec1-d04f521cbb56",
          "artist_credit_name": "Daft Punk",
          "join_phrase": " feat. "
        },
        {
          "artist_mbid": "c5ce487b-0462-444e-a184-4de0fef7e028",
          "artist_credit_name": "Julian Casablancas",
          "join_phrase": ""
        }
      ],
      "artist_mbids": [
        "056e4f3e-d505-4dad-8ec1-d04f521cbb56",
        "c5ce487b-0462-444e-a184-4de0fef7e028"
      ],
      "caa_id": 32554171842,
      "caa_release_mbid": "5000a285-b67e-4cfc-b54b-2b98f1810d2e"
    }
  },
  "listened_at": 1694479888,
  "recording_msid": "878c787e-5dd4-42b4-9c2b-1b53baec7e8b",
  "user_name": "kinescou",
  "inserted_at": 1694480058
}
2023-09-11T20:55:10-04:00 debug : [Scrobblers] [Maloja - Maloja] Raw Payload: {"album":"Random Access Memories","artists":["Daft Punk","Da","Punk","Julian Casablancas"],"key":"key","length":338,"time":1694479888,"title":"Instant Crush"}
2023-09-11T20:55:10-04:00 info : [Scrobblers] [Maloja - Maloja] Scrobbled (Backlog) => (listenbrainz) Daft Punk / Da / Punk / Julian Casablancas - Instant Crush @ 2023-09-11T20:51:28-04:00`

This happens with every song by Daft Punk across a variety of sources (desktop music player, Web Scrobbler, Pano Scrobbler).

It might be that it's seeing the ft in the artist's name as an artist separator instead of as part of their name.

FoxxMD commented 9 months ago

Thanks for the detailed writeup and listenbrainz data! That made it super easy to reproduce and fix this.

This should be fixed in the develop branch now.

ghost commented 9 months ago

Thank you, works great!

FoxxMD commented 9 months ago

This is now available in the latest docker image, master git branch, and 0.5.2 docker image/git tag.