Fix to allow text input in web components.

Foxy / chrome-type-ahead

Find-as-you-type extension for Chrome and Edge.

MIT License

14 stars 5 forks source link

Fix to allow text input in web components. #9

Closed brettflorio closed 4 years ago

brettflorio commented 4 years ago

Without this, the extension will perform a search instead of allowing input. To see this in action, try the following:

The search input here: http://www.twelvetone.tv/iron-icons-search/index.html
The email input here: https://vaadin.com/components/vaadin-email-field/html-examples/email-field-demos
Combo box text input: https://vaadin.com/components/vaadin-combo-box/html-examples
Any other text input inside a web component.

There may be a better way to allow text input inside web components, but this small change seems to fix the problem without breaking anything else (at least in my own usage so far).

tokland commented 4 years ago

Thx, @brettflorio !

brettflorio commented 4 years ago

@tokland Happy to be able to contribute :) Thanks for your time and attention in merging it in!

brettflorio commented 4 years ago

@tokland If I can help further in terms of getting it updated on the Chrome extension site, just let me know.

tokland commented 4 years ago

I've submitted the extension for publishing. It will need to be reviewed, let's see.

brettflorio commented 4 years ago

@tokland Any word about the review process? Curious what kind of timeframe that typically happens in. Thanks!

brettflorio commented 3 years ago

@tokland I'm wondering if we need to bump the version for Google to pick up the latest version? This PR still isn't live in the Chrome Web Store. If you'd like to me to submit another PR with a version bump, lmk. Thanks!

tokland commented 3 years ago

I don't use the extension anymore. Would you be interested in maintaining the code and publishing it?

brettflorio commented 3 years ago

@tokland I'd be happy to, as I use it every day, all the time, so keeping it updated shouldn't be an issue (especially as it's proven to be remarkably stable over the years). I've emailed you if you'd like to discuss there, or we can continue here.