search

Fr33dan / GPSaveConverter

Utility to transfer save files between the games installed from the Xbox app and other storefronts. https://ko-fi.com/fr33dan
297 stars 33 forks source link

Skip packages that aren't found in the UWP library #2

Closed jbyauk closed 2 years ago

jbyauk commented 2 years ago

Thanks for making this tool!

While trying to transfer my Guardians of the Galaxy save file, I ran into the same issue as in this reddit comment. I have a couple package folders, Microsoft.Chelan_8wekyb3d8bbwe and Microsoft.Maine_8wekyb3d8bbwe, which are causing the Game info not found in UWP library exception to be thrown. The first appears related to the Halo MCC, and the second Obsidian's Grounded game.

I'm not sure why these aren't recognized, but either way I was able to successfully copy my Guardians save after I added the code in this commit to log and skip folders for packages not found in the UWP library.

Fr33dan commented 2 years ago

Thank you for the fix!

I saw this happen for an app that was flagged as corrupt when I was debugging something else, but fixed the app to finish what I was working on and forgot about this potentiality to add a fix.

Are there updates pending for these games? I'm running on the theory that maybe if the app isn't ready to run, UWP doesn't report information on it.

I'm pulling this in because it's a good idea to not have a crash in the event of a problem loading game info and to just skip it, but in the long run I think it would be better to just list the game without the UWP info, since it could still contain valid save data.

jbyauk commented 2 years ago

Are there updates pending for these games? I'm running on the theory that maybe if the app isn't ready to run, UWP doesn't report information on it.

Interesting, it looks like you're right-- I think my installations of these two games are messed up somehow. They aren't showing updates in the Xbox app, but when I click "Play" I get an error message saying "This app can't open", "<app> can't open because it is offline, The storage device might be missing or disconnected."

in the long run I think it would be better to just list the game without the UWP info, since it could still contain valid save data.

Ah good idea, I agree this is probably a better approach.